fixed an issue with session manager interface

This commit is contained in:
2025-12-18 13:30:02 -05:00
parent fd0458cc08
commit 1c9688efd0
3 changed files with 8 additions and 33 deletions

View File

@@ -34,11 +34,7 @@ func HandleLogin(deps *deps) http.HandlerFunc {
deps.log.Info("generated state", "state", state)
if err = deps.sessions.Put(r.Context(), StateKey, state); err != nil {
deps.log.Error("unable to store state in session", "error", err)
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
deps.sessions.Put(r.Context(), StateKey, state)
http.Redirect(w, r, deps.auth.AuthCodeURL(state), http.StatusFound)
}
@@ -46,13 +42,8 @@ func HandleLogin(deps *deps) http.HandlerFunc {
func HandleLogout(deps *deps) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
if err := deps.sessions.Put(r.Context(), "user", nil); err != nil {
deps.log.Error("unable to remove user from session", "error", err)
}
if err := deps.sessions.Put(r.Context(), StateKey, nil); err != nil {
deps.log.Error("unable to remove state from session", "error", err)
}
deps.sessions.Put(r.Context(), "user", nil)
deps.sessions.Put(r.Context(), StateKey, nil)
scheme := "http"
if r.TLS != nil {
@@ -85,9 +76,7 @@ func HandleCallback(deps *deps) http.HandlerFunc {
return
}
if err := deps.sessions.Put(r.Context(), StateKey, nil); err != nil {
deps.log.Error("unable to remove state from session", "error", err)
}
deps.sessions.Put(r.Context(), StateKey, nil)
token, err := deps.auth.Exchange(r.Context(), r.URL.Query().Get("code"))
if err != nil {
@@ -110,17 +99,8 @@ func HandleCallback(deps *deps) http.HandlerFunc {
return
}
if err = deps.sessions.Put(r.Context(), "user", profile); err != nil {
deps.log.Error("unable to store user profile in session", "error", err)
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
if err = deps.sessions.Put(r.Context(), "access_token", token.AccessToken); err != nil {
deps.log.Error("unable to store access token in session", "error", err)
http.Error(w, err.Error(), http.StatusInternalServerError)
return
}
deps.sessions.Put(r.Context(), "user", profile)
deps.sessions.Put(r.Context(), "access_token", token.AccessToken)
http.Redirect(w, r, "/", http.StatusFound)
}